feat(search): fill the empty search page with rows instead of three #9

Merged

techfather merged 2 commits from feat/search-more-rows into main 2026-10-18 14:07:32 -07:00

Conversation 1 Commits 2 Files changed 5 +174 -19

techfather commented 2026-10-18 13:57:24 -07:00

Owner

• Copy link
• Copy Markdown

The empty /search state rendered a heading plus three rows, which still reads as a mostly empty page.

• Picks now lead with the personal rows (recommended, more-like repeats, unexpected picks) and continue with the shared catalog rows, capped at eight rows, empty rows still dropped.
• The personal/discovery split moved into lib/rails.ts and is shared by the feed and the search page, so the two cannot drift apart again (the numbered more-like repeats were the source of the earlier mismatch: two of the three related rows were being classified as Explore rows).

Tests: Vitest 196/196 (5 new in reads: lib/rails.test.ts plus a row-order/count case in Search), tsc -b clean, Biome clean.

The empty /search state rendered a heading plus **three** rows, which still reads as a mostly empty page. - Picks now lead with the personal rows (recommended, more-like repeats, unexpected picks) and continue with the shared catalog rows, capped at eight rows, empty rows still dropped. - The personal/discovery split moved into `lib/rails.ts` and is shared by the feed and the search page, so the two cannot drift apart again (the numbered more-like repeats were the source of the earlier mismatch: two of the three related rows were being classified as Explore rows). Tests: Vitest 196/196 (5 new in reads: lib/rails.test.ts plus a row-order/count case in Search), tsc -b clean, Biome clean.

techfather added 1 commit 2026-10-18 13:57:24 -07:00

feat(search): fill the empty search page with rows instead of three ... 307e7e6634

Landing on /search showed a heading plus three rows, which still reads as a
mostly empty page. The picks now lead with the personal rows and continue with
the shared catalog rows, up to eight rows, skipping empty ones.

The personal/discovery split moved into lib/rails.ts so the feed and the search
page cannot drift apart again (the numbered "more-like" repeats were the source
of the earlier mismatch).

forgejo-review-bot approved these changes 2026-10-18 14:00:03 -07:00

forgejo-review-bot left a comment

• Copy link
• Copy Markdown

Local automated review (forgejo-autocheck).

Required checks are green on 307e7e6634: 3/3.

• gate / e2e (pull_request): success
• security / advisories (pull_request): success
• gate / container-smoke (pull_request): success
• gate / check (pull_request): success

Detected stack: repo, python, container.
Approving so the change is not blocked on a second human reviewer.

Local automated review (forgejo-autocheck). Required checks are green on 307e7e6634: 3/3. - gate / e2e (pull_request): success - security / advisories (pull_request): success - gate / container-smoke (pull_request): success - gate / check (pull_request): success Detected stack: repo, python, container. Approving so the change is not blocked on a second human reviewer.

techfather added 1 commit 2026-10-18 14:03:32 -07:00

Merge branch 'main' into feat/search-more-rows 3f9c0a5143

techfather merged commit 4cdaed4fb7 into main 2026-10-18 14:07:32 -07:00

techfather referenced this pull request from a commit 2026-10-18 14:07:34 -07:00

Merge pull request #9

Sign in to join this conversation.

Reviewers

No reviewers

forgejo-review-bot

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

techfather/tasterr!9

No description provided.